[bisq-network/bisq] Send pretty payment details to API clients (PR #6103)
Stan
notifications at github.com
Sat Mar 12 18:51:15 CET 2022
Non-CLI clients need a better way of accessing payment details than a contract json string.
- Add `grpc.proto` `PaymentAccountPayloadInfo` field: payment_details.
- Adjust proto wrapper `PaymentAccountPayloadInfo` to new field.
- Add test asserts to verify payment details are sent to client.
- Fix a test name: `testKeepFunds` -> `testCloseTrade`.
Based on branch `master` @ Sat 12 Mar 2022 01:42 PM -03, commit c6293b52730e59c675953fc8cff9238d0efd7edc
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/6103
-- Commit Summary --
* Send pretty payment details to api clients
-- File Changes --
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (28)
M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (2)
M core/src/main/java/bisq/core/api/model/PaymentAccountPayloadInfo.java (22)
M proto/src/main/proto/grpc.proto (1)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/6103.patch
https://github.com/bisq-network/bisq/pull/6103.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/6103
You are receiving this because you are subscribed to this thread.
Message ID: <bisq-network/bisq/pull/6103 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20220312/269133e8/attachment-0001.htm>
More information about the bisq-github
mailing list