[bisq-network/bisq] Dark Mode (#3152)

Peter Banik notifications at github.com
Wed Aug 28 13:59:05 UTC 2019

> @peterzen I am just a spectator who joined the project recently (not involved in this PR). The way I see it is that Bisq is very short on experienced reviewers and technical project management.
> For that reason it often requires some pushing and management by the PR **author** to get the changes merged in.
> In any case, you definitely should be credited for your hard work on this regardless of who does the "final push".

OK fair enough, as I said I'm happy that this is moving forward - but I still think it would have been much nicer if @wiz added a couple of lines of comment which I would have turned around in a day.  That way, the contributor process would have been closely followed - in this scenario how could I possibly sign my patch (in accordance with the C4 process), it just doesn't feel right.

I don't mean to make a fuss of this and don't want to waste any more developer time - it's just that if a contributor did this to another contributor's patch in, say, the Decred project to which I contribute a lot, he/she would have been frowned upon to say the least.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190828/1374e41f/attachment.html>

More information about the bisq-github mailing list