[bisq-network/bisq-website] [WIP] Refactored "Statistics" page to make it more i18n friendly (#221)

huey735 notifications at github.com
Wed Aug 28 18:10:58 UTC 2019


@m52go @erciccione 
The strings_en.yml must have the same keys/variables as the other languages' .yml files. strings_en.yml is what's fed to Transifex to output the translated versions. There are two ways to go about these changes.
1. We can put only the "stable" strings like "pTotalTrades: Total Trades" on the .yml files and leave the "unstable" strings, the figures, on the stats.html file. And @m52go would regularly update only the stats.html file.
2. The other way is to have all English strings in the strings_en and in the other languages' .yml files.

> @huey735 what's the best way to do this? Simple question on Slack?

Yes, for that I think we can do it quickly through Slack. But I think that the better work flow is to have the changes done to the English pages and strings_en.yml, merged so that Transifex can fetch the changes and then download the translations when they're done and merge them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/221#issuecomment-525860167
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190828/b51db8ab/attachment.html>


More information about the bisq-github mailing list