[bisq-network/bisq] Dao avoid bsq burn (#2242)

Manfred Karrer notifications at github.com
Sun Feb 3 15:02:08 UTC 2019

ManfredKarrer requested changes on this pull request.

> @@ -248,10 +248,15 @@ private void processIssuance(int blockHeight, TempTx tempTx, long bsqFee) {
                 log.warn("It can be that we have a opReturn which is correct from its structure but the whole tx " +
                         "in not valid as the issuanceCandidate in not there. " +
                         "As the BSQ fee is set it must be either a buggy tx or an manually crafted invalid tx.");
-                tempTx.setTxType(TxType.INVALID);
+                // Even though the request part if invalid the BSQ transfer and change output should still be valid
+                // as long as the BSQ change <= BSQ inputs.
+                tempTx.setTxType(TxType.UNDEFINED_TX_TYPE);

Not sure if we should use UNDEFINED_TX_TYPE as it does not describe it correctly. Maybe some weaker term than "invalid"? What about NON_STANDARD or "NON_RULED_COMFORM"? 

> @@ -53,8 +53,10 @@ protected Bond(T bondedAsset) {
     public boolean isActive() {
-        return bondState != BondState.READY_FOR_LOCKUP &&
-                bondState != BondState.UNLOCKED;
+        return bondState == BondState.LOCKUP_TX_CONFIRMED ||

I think UNLOCK_TX_PENDING is missing

> @@ -1635,7 +1635,8 @@ dao.wallet.dashboard.price=Latest BSQ/BTC trade price (in Bisq)
 dao.wallet.dashboard.marketCap=Market capitalisation (based on trade price)
 dao.wallet.receive.fundYourWallet=Fund your BSQ wallet
-dao.wallet.receive.bsqAddress=BSQ wallet address
+dao.wallet.receive.bsqAddress=BSQ wallet address (This is a new unused address to avoid address reuse, \

That is quite verbose. What about:
Fresh unused BSQ wallet address

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190203/6b644de5/attachment.html>

More information about the bisq-github mailing list