[bisq-network/bisq] Make stateless BSFormatter functions static and remove dead code (#3239)

[Justin Carter]

> making the method static is only useful if you really move the method. so to see if it makes sense the move needs to be in the same pr.

I disagree. Reducing the public api of the BSFormatter _instance_ is useful in itself as it makes it possible to see in the calling code if there is a dependency on hidden state or the function is stateless.

Either way I will open another PR with the first move included.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3239#issuecomment-530301677
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190911/ac095467/attachment.html>