[bisq-network/bisq] Update MobileModel parseDescriptor to support iPhone 11 (#3277)

[Devin Bileck]

devinbileck commented on this pull request.



>                          return true;
+                    }
+                    if (versionString.matches("\\d[^\\d]")) {
+                        versionString = versionString.substring(0, 1);
+                    } else if (versionString.matches("\\d{2}[^\\d]")) {
+                        versionString = versionString.substring(0, 2);
+                    }
                     try {
                         int version = Integer.parseInt(versionString);
                         return version > 5;

One thing I would like clarification on, if anyone knows...

>From the comment on [line 134](https://github.com/bisq-network/bisq/pull/3277/files#diff-975a294e288c01124c0bb32007568ffcR134):
>         // iPhone 6 does not support isContentAvailable, iPhone 7 does.
>         // We don't know for other versions, but lets assume all above iPhone 6 are ok.

If that is the case, I assume this should be changed to:
`return version > 6;`

Unless the comment is incorrect?

I am not familiar with isContentAvailable, but is this capability really device dependent?
It appears content-available was added to notifications in iOS7: https://stackoverflow.com/questions/20690220/proper-use-of-content-available-in-ios-7-push-notifications
And iOS7 is supported as far back as iPhone 4: http://osxdaily.com/2013/06/10/ios-7-supported-devices/

So then maybe it should be:
`return version >= 4;`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3277#pullrequestreview-289063780
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190917/2e015e3c/attachment.html>