[bisq-network/bisq] Make serialisation in FileManager::saveToFile thread-safe (#4025)

Christoph Atteneder notifications at github.com
Tue Mar 17 14:58:51 UTC 2020


> Regarding `VoteWithProposalTxIdList` and `MeritList`: Yes I also assume there is no issue but I think its more safe to use a dedicated class to avoid potential future issues. Those classes implement also the `ConsensusCritical` marker interface.

@ManfredKarrer Is this a requirement for this PR to get merged? If not please NACK or if it is up to be merged ACK from your side to make it clear for the maintainers 😄 . Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4025#issuecomment-600117547
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200317/7e328a1f/attachment.html>


More information about the bisq-github mailing list